Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: prepare ./tools/compress_json.py for Python 3 #24889

Closed
wants to merge 1 commit into from
Closed

tools: prepare ./tools/compress_json.py for Python 3 #24889

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 7, 2018
@Trott
Copy link
Member

Trott commented Dec 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19303/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2018
@Trott
Copy link
Member

Trott commented Dec 7, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19312/

@Trott
Copy link
Member

Trott commented Dec 10, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19378/

@Trott
Copy link
Member

Trott commented Dec 10, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19401/

@Trott
Copy link
Member

Trott commented Dec 10, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19406/

@Trott
Copy link
Member

Trott commented Dec 11, 2018 •
edited
Loading

Landed in ad7ddfb

@Trott Trott closed this Dec 11, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 11, 2018
@Trott
tools: prepare ./tools/compress_json.py for Python 3
ad7ddfb 
PR-URL: nodejs#24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@cclauss cclauss deleted the Py3-for-tools-compress_json.py branch December 11, 2018 03:51
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@BethGriggs
tools: prepare ./tools/compress_json.py for Python 3
16a75be 
PR-URL: #24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
tools: prepare ./tools/compress_json.py for Python 3
bd97ea1 
PR-URL: nodejs#24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
tools: prepare ./tools/compress_json.py for Python 3
5cbc0db 
PR-URL: #24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
tools: prepare ./tools/compress_json.py for Python 3
15a853e 
PR-URL: #24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
tools: prepare ./tools/compress_json.py for Python 3
ea50080 
PR-URL: #24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020
@BaochengSu
tools: prepare ./tools/compress_json.py for Python 3
a383626 
PR-URL: nodejs#24889
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
(cherry picked from commit ad7ddfb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cclauss @Trott @richardlau @BethGriggs @nodejs-github-bot